Remove DataService and OfflineDataService, refactor book and character operations to use streamlined handlers in LocalSystem

- Delete `data.service.ts` and `offline-data.service.ts`, consolidating functionality into `LocalSystem`. - Refactor book, character, and conversation operations to adopt unified, multilingual, and session-enabled IPC handlers in `LocalSystem`. - Simplify redundant legacy methods, enhancing maintainability and consistency.
2025-11-18 21:02:38 -05:00
parent d46aecc80d
commit d018e75be4
11 changed files with 222 additions and 1111 deletions
--- a/electron/ipc/book.ipc.ts
+++ b/electron/ipc/book.ipc.ts
@@ -1,34 +1,30 @@
 import { ipcMain } from 'electron';
-import {
-    createDbHandler2,
-    // Auto-handlers: automatically inject userId AND lang
-    createAutoHandler,
-    createAutoHandler1
-} from '../database/LocalSystem.js';
+import { createHandler } from '../database/LocalSystem.js';
 import Book from '../database/models/Book.js';
 import type { BookProps, GuideLine, GuideLineAI, Act, Issue, WorldProps } from '../database/models/Book.js';

-ipcMain.handle(
-    'db:book:getAll',
-    createAutoHandler<BookProps[]>(
-        async function(userId: string, lang: 'fr' | 'en') {
+// ============================================================
+// 1. GET /books - Get all books
+// ============================================================
+ipcMain.handle('db:book:books', createHandler<void, BookProps[]>(
+        async function(userId: string, _body: void, lang: 'fr' | 'en'):Promise<BookProps[]> {
            return await Book.getBooks(userId, lang);
        }
    )
 );

-ipcMain.handle(
-    'db:book:get',
-    createAutoHandler1<string, BookProps>(
-        async function(userId: string, bookId: string, lang: 'fr' | 'en') {
-            return await Book.getBook(bookId, userId, lang);
+// ============================================================
+// 2. GET /book/:id - Get single book
+// ============================================================
+ipcMain.handle('db:book:bookBasicInformation', createHandler<string, BookProps>(
+        async function(userId: string, bookId: string, lang: 'fr' | 'en'):Promise<BookProps> {
+            return await Book.getBook(bookId, userId);
        }
    )
 );
-// Frontend call: await window.electron.invoke('db:book:get', bookId);

 // ============================================================
-// 3. POST /book/basic-information
+// 3. POST /book/basic-information - Update book basic info
 // ============================================================
 interface UpdateBookBasicData {
    title: string;
@@ -41,7 +37,7 @@ interface UpdateBookBasicData {

 ipcMain.handle(
    'db:book:updateBasicInformation',
-    createAutoHandler1<UpdateBookBasicData, boolean>(
+    createHandler<UpdateBookBasicData, boolean>(
        function(userId: string, data: UpdateBookBasicData, lang: 'fr' | 'en') {
            return Book.updateBookBasicInformation(
                userId,
@@ -56,22 +52,23 @@ ipcMain.handle(
        }
    )
 );
-// Frontend call: await window.electron.invoke('db:book:updateBasicInformation', data);
+// Frontend: invoke('db:book:updateBasicInformation', data)

 // ============================================================
-// 4. GET /book/guide-line
+// 4. GET /book/guide-line - Get guideline
 // ============================================================
 ipcMain.handle(
    'db:book:guideline:get',
-    createAutoHandler1<string, GuideLine | null>(
+    createHandler<string, GuideLine | null>(
        async function(userId: string, bookId: string, lang: 'fr' | 'en') {
            return await Book.getGuideLine(userId, bookId, lang);
        }
    )
 );
+// Frontend: invoke('db:book:guideline:get', bookId)

 // ============================================================
-// 5. POST /book/guide-line
+// 5. POST /book/guide-line - Update guideline
 // ============================================================
 interface UpdateGuideLineData {
    bookId: string;
@@ -89,7 +86,7 @@ interface UpdateGuideLineData {

 ipcMain.handle(
    'db:book:guideline:update',
-    createAutoHandler1<UpdateGuideLineData, boolean>(
+    createHandler<UpdateGuideLineData, boolean>(
        async function(userId: string, data: UpdateGuideLineData, lang: 'fr' | 'en') {
            return await Book.updateGuideLine(
                userId,
@@ -109,9 +106,10 @@ ipcMain.handle(
        }
    )
 );
+// Frontend: invoke('db:book:guideline:update', data)

 // ============================================================
-// 6. GET /book/story
+// 6. GET /book/story - Get story data (acts + issues)
 // ============================================================
 interface StoryData {
    acts: Act[];
@@ -120,7 +118,7 @@ interface StoryData {

 ipcMain.handle(
    'db:book:story:get',
-    createDbHandler2<string, 'fr' | 'en', StoryData>(
+    createHandler<string, StoryData>(
        async function(userId: string, bookId: string, lang: 'fr' | 'en') {
            const acts = await Book.getActsData(userId, bookId, lang);
            const issues = await Book.getIssuesFromBook(userId, bookId, lang);
@@ -131,9 +129,10 @@ ipcMain.handle(
        }
    )
 );
+// Frontend: invoke('db:book:story:get', bookId)

 // ============================================================
-// 7. POST /book/story
+// 7. POST /book/story - Update story
 // TODO: Implement updateStory in Book.ts
 // ============================================================
 // interface StoryUpdateData {
@@ -144,15 +143,16 @@ ipcMain.handle(
 //
 // ipcMain.handle(
 //     'db:book:story:update',
-//     createDbHandler2<StoryUpdateData, 'fr' | 'en', boolean>(
+//     createHandler<StoryUpdateData, boolean>(
 //         function(userId: string, data: StoryUpdateData, lang: 'fr' | 'en') {
 //             return Book.updateStory(userId, data.bookId, data.acts, data.mainChapters, lang);
 //         }
 //     )
 // );
+// // Frontend: invoke('db:book:story:update', data)

 // ============================================================
-// 8. POST /book/add
+// 8. POST /book/add - Create new book
 // ============================================================
 interface CreateBookData {
    title: string;
@@ -166,7 +166,7 @@ interface CreateBookData {

 ipcMain.handle(
    'db:book:create',
-    createDbHandler2<CreateBookData, 'fr' | 'en', string>(
+    createHandler<CreateBookData, string>(
        function(userId: string, data: CreateBookData, lang: 'fr' | 'en') {
            return Book.addBook(
                null,
@@ -183,22 +183,29 @@ ipcMain.handle(
        }
    )
 );
+// Frontend: invoke('db:book:create', data)

 // ============================================================
-// 9. POST /book/cover
-// ============================================================
+// 9. POST /book/cover - Update book cover
 // TODO: Implement updateBookCover in Book.ts
+// ============================================================
+// interface UpdateCoverData {
+//     bookId: string;
+//     coverImageName: string;
+// }
+//
 // ipcMain.handle(
 //     'db:book:cover:update',
-//     createDbHandler3<string, string, 'fr' | 'en', boolean>(
-//         function(userId: string, bookId: string, coverImageName: string, lang: 'fr' | 'en') {
-//             return Book.updateBookCover(userId, bookId, coverImageName, lang);
+//     createHandler<UpdateCoverData, boolean>(
+//         function(userId: string, data: UpdateCoverData, lang: 'fr' | 'en') {
+//             return Book.updateBookCover(userId, data.bookId, data.coverImageName, lang);
 //         }
 //     )
 // );
+// // Frontend: invoke('db:book:cover:update', { bookId, coverImageName })

 // ============================================================
-// 10. POST /book/incident/new
+// 10. POST /book/incident/new - Add incident
 // ============================================================
 interface AddIncidentData {
    bookId: string;
@@ -207,15 +214,16 @@ interface AddIncidentData {

 ipcMain.handle(
    'db:book:incident:add',
-    createDbHandler2<AddIncidentData, 'fr' | 'en', string>(
+    createHandler<AddIncidentData, string>(
        function(userId: string, data: AddIncidentData, lang: 'fr' | 'en') {
            return Book.addNewIncident(userId, data.bookId, data.name, lang);
        }
    )
 );
+// Frontend: invoke('db:book:incident:add', { bookId, name })

 // ============================================================
-// 11. DELETE /book/incident/remove
+// 11. DELETE /book/incident/remove - Remove incident
 // ============================================================
 interface RemoveIncidentData {
    bookId: string;
@@ -224,15 +232,16 @@ interface RemoveIncidentData {

 ipcMain.handle(
    'db:book:incident:remove',
-    createDbHandler2<RemoveIncidentData, 'fr' | 'en', boolean>(
+    createHandler<RemoveIncidentData, boolean>(
        function(userId: string, data: RemoveIncidentData, lang: 'fr' | 'en') {
            return Book.removeIncident(userId, data.bookId, data.incidentId, lang);
        }
    )
 );
+// Frontend: invoke('db:book:incident:remove', { bookId, incidentId })

 // ============================================================
-// 12. POST /book/plot/new
+// 12. POST /book/plot/new - Add plot point
 // ============================================================
 interface AddPlotPointData {
    bookId: string;
@@ -242,7 +251,7 @@ interface AddPlotPointData {

 ipcMain.handle(
    'db:book:plot:add',
-    createDbHandler2<AddPlotPointData, 'fr' | 'en', string>(
+    createHandler<AddPlotPointData, string>(
        function(userId: string, data: AddPlotPointData, lang: 'fr' | 'en') {
            return Book.addNewPlotPoint(
                userId,
@@ -254,21 +263,23 @@ ipcMain.handle(
        }
    )
 );
+// Frontend: invoke('db:book:plot:add', { bookId, name, incidentId })

 // ============================================================
-// 13. DELETE /book/plot/remove
+// 13. DELETE /book/plot/remove - Remove plot point
 // ============================================================
 ipcMain.handle(
    'db:book:plot:remove',
-    createDbHandler2<string, 'fr' | 'en', boolean>(
+    createHandler<string, boolean>(
        function(userId: string, plotPointId: string, lang: 'fr' | 'en') {
            return Book.removePlotPoint(userId, plotPointId, lang);
        }
    )
 );
+// Frontend: invoke('db:book:plot:remove', plotPointId)

 // ============================================================
-// 14. POST /book/issue/add
+// 14. POST /book/issue/add - Add issue
 // ============================================================
 interface AddIssueData {
    bookId: string;
@@ -277,39 +288,42 @@ interface AddIssueData {

 ipcMain.handle(
    'db:book:issue:add',
-    createDbHandler2<AddIssueData, 'fr' | 'en', string>(
+    createHandler<AddIssueData, string>(
        function(userId: string, data: AddIssueData, lang: 'fr' | 'en') {
            return Book.addNewIssue(userId, data.bookId, data.name, lang);
        }
    )
 );
+// Frontend: invoke('db:book:issue:add', { bookId, name })

 // ============================================================
-// 15. DELETE /book/issue/remove
+// 15. DELETE /book/issue/remove - Remove issue
 // ============================================================
 ipcMain.handle(
    'db:book:issue:remove',
-    createDbHandler2<string, 'fr' | 'en', boolean>(
+    createHandler<string, boolean>(
        function(userId: string, issueId: string, lang: 'fr' | 'en') {
            return Book.removeIssue(userId, issueId, lang);
        }
    )
 );
+// Frontend: invoke('db:book:issue:remove', issueId)

 // ============================================================
-// 16. GET /book/worlds
+// 16. GET /book/worlds - Get worlds for book
 // ============================================================
 ipcMain.handle(
    'db:book:worlds:get',
-    createDbHandler2<string, 'fr' | 'en', WorldProps[]>(
+    createHandler<string, WorldProps[]>(
        function(userId: string, bookId: string, lang: 'fr' | 'en') {
            return Book.getWorlds(userId, bookId, lang);
        }
    )
 );
+// Frontend: invoke('db:book:worlds:get', bookId)

 // ============================================================
-// 17. POST /book/world/add
+// 17. POST /book/world/add - Add world
 // ============================================================
 interface AddWorldData {
    bookId: string;
@@ -318,15 +332,16 @@ interface AddWorldData {

 ipcMain.handle(
    'db:book:world:add',
-    createDbHandler2<AddWorldData, 'fr' | 'en', string>(
+    createHandler<AddWorldData, string>(
        function(userId: string, data: AddWorldData, lang: 'fr' | 'en') {
            return Book.addNewWorld(userId, data.bookId, data.worldName, lang);
        }
    )
 );
+// Frontend: invoke('db:book:world:add', { bookId, worldName })

 // ============================================================
-// 18. POST /book/world/element/add
+// 18. POST /book/world/element/add - Add element to world
 // ============================================================
 interface AddWorldElementData {
    worldId: string;
@@ -336,7 +351,7 @@ interface AddWorldElementData {

 ipcMain.handle(
    'db:book:world:element:add',
-    createDbHandler2<AddWorldElementData, 'fr' | 'en', string>(
+    createHandler<AddWorldElementData, string>(
        function(userId: string, data: AddWorldElementData, lang: 'fr' | 'en') {
            return Book.addNewElementToWorld(
                userId,
@@ -348,71 +363,77 @@ ipcMain.handle(
        }
    )
 );
+// Frontend: invoke('db:book:world:element:add', { worldId, elementName, elementType })

 // ============================================================
-// 19. DELETE /book/world/element/delete
+// 19. DELETE /book/world/element/delete - Remove element from world
 // ============================================================
 ipcMain.handle(
    'db:book:world:element:remove',
-    createDbHandler2<string, 'fr' | 'en', boolean>(
+    createHandler<string, boolean>(
        function(userId: string, elementId: string, lang: 'fr' | 'en') {
            return Book.removeElementFromWorld(userId, elementId, lang);
        }
    )
 );
+// Frontend: invoke('db:book:world:element:remove', elementId)

 // ============================================================
-// 20. PUT /book/world/update
+// 20. PUT /book/world/update - Update world
 // TODO: Implement updateWorld in Book.ts
 // ============================================================
 // ipcMain.handle(
 //     'db:book:world:update',
-//     createDbHandler2<WorldProps, 'fr' | 'en', boolean>(
+//     createHandler<WorldProps, boolean>(
 //         function(userId: string, world: WorldProps, lang: 'fr' | 'en') {
 //             return Book.updateWorld(userId, world, lang);
 //         }
 //     )
 // );
+// // Frontend: invoke('db:book:world:update', worldData)

 // ============================================================
-// 21. DELETE /book/cover/delete
+// 21. DELETE /book/cover/delete - Delete book cover
 // TODO: Implement deleteCoverPicture in Book.ts
 // ============================================================
 // ipcMain.handle(
 //     'db:book:cover:delete',
-//     createDbHandler2<string, 'fr' | 'en', boolean>(
+//     createHandler<string, boolean>(
 //         function(userId: string, bookId: string, lang: 'fr' | 'en') {
 //             return Book.deleteCoverPicture(userId, bookId, lang);
 //         }
 //     )
 // );
+// // Frontend: invoke('db:book:cover:delete', bookId)

 // ============================================================
-// 22. DELETE /book/delete
+// 22. DELETE /book/delete - Delete book
 // ============================================================
 ipcMain.handle(
    'db:book:delete',
-    createDbHandler2<string, 'fr' | 'en', boolean>(
+    createHandler<string, boolean>(
        function(userId: string, bookId: string, lang: 'fr' | 'en') {
            return Book.removeBook(userId, bookId, lang);
        }
    )
 );
+// Frontend: invoke('db:book:delete', bookId)

 // ============================================================
-// 23. GET /book/ai/guideline
+// 23. GET /book/ai/guideline - Get AI guideline
 // ============================================================
 ipcMain.handle(
    'db:book:guideline:ai:get',
-    createDbHandler2<string, 'fr' | 'en', GuideLineAI>(
+    createHandler<string, GuideLineAI>(
        function(userId: string, bookId: string, lang: 'fr' | 'en') {
            return Book.getGuideLineAI(bookId, userId, lang);
        }
    )
 );
+// Frontend: invoke('db:book:guideline:ai:get', bookId)

 // ============================================================
-// 24. POST /book/ai/guideline (set)
+// 24. POST /book/ai/guideline (set) - Set AI guideline
 // ============================================================
 interface SetAIGuideLineData {
    bookId: string;
@@ -427,7 +448,7 @@ interface SetAIGuideLineData {

 ipcMain.handle(
    'db:book:guideline:ai:set',
-    createDbHandler2<SetAIGuideLineData, 'fr' | 'en', boolean>(
+    createHandler<SetAIGuideLineData, boolean>(
        function(userId: string, data: SetAIGuideLineData, lang: 'fr' | 'en') {
            return Book.setAIGuideLine(
                data.bookId,
@@ -444,48 +465,52 @@ ipcMain.handle(
        }
    )
 );
+// Frontend: invoke('db:book:guideline:ai:set', data)

 // ============================================================
-// 25. GET /book/transform/epub
-// ============================================================
+// 25. GET /book/transform/epub - Export to EPUB
 // TODO: Implement transformToEpub in Book.ts
+// ============================================================
 // ipcMain.handle(
 //     'db:book:export:epub',
-//     createDbHandler2<string, 'fr' | 'en', ExportData>(
+//     createHandler<string, ExportData>(
 //         function(userId: string, bookId: string, lang: 'fr' | 'en') {
 //             return Book.transformToEpub(userId, bookId, lang);
 //         }
 //     )
 // );
+// // Frontend: invoke('db:book:export:epub', bookId)

 // ============================================================
-// 26. GET /book/transform/pdf
-// ============================================================
+// 26. GET /book/transform/pdf - Export to PDF
 // TODO: Implement transformToPDF in Book.ts
+// ============================================================
 // ipcMain.handle(
 //     'db:book:export:pdf',
-//     createDbHandler2<string, 'fr' | 'en', ExportData>(
+//     createHandler<string, ExportData>(
 //         function(userId: string, bookId: string, lang: 'fr' | 'en') {
 //             return Book.transformToPDF(userId, bookId, lang);
 //         }
 //     )
 // );
+// // Frontend: invoke('db:book:export:pdf', bookId)

 // ============================================================
-// 27. GET /book/transform/docx
-// ============================================================
+// 27. GET /book/transform/docx - Export to DOCX
 // TODO: Implement transformToDOCX in Book.ts
+// ============================================================
 // ipcMain.handle(
 //     'db:book:export:docx',
-//     createDbHandler2<string, 'fr' | 'en', ExportData>(
+//     createHandler<string, ExportData>(
 //         function(userId: string, bookId: string, lang: 'fr' | 'en') {
 //             return Book.transformToDOCX(userId, bookId, lang);
 //         }
 //     )
 // );
+// // Frontend: invoke('db:book:export:docx', bookId)

 // ============================================================
-// 28. GET /book/tags
+// 28. GET /book/tags - Get tags from book
 // TODO: Implement getTagsFromBook in Book.ts
 // ============================================================
 // interface BookTags {
@@ -497,11 +522,12 @@ ipcMain.handle(
 //
 // ipcMain.handle(
 //     'db:book:tags:get',
-//     createDbHandler2<string, 'fr' | 'en', BookTags>(
+//     createHandler<string, BookTags>(
 //         function(userId: string, bookId: string, lang: 'fr' | 'en') {
 //             return Book.getTagsFromBook(userId, bookId, lang);
 //         }
 //     )
 // );
+// // Frontend: invoke('db:book:tags:get', bookId)

 console.log('[IPC] Book handlers registered');